Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @nmittler to CODEOWNERs top level #28855

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Nov 13, 2020

Backfill after Shriram left to avoid bus factor of only having 3 of us

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any changes that may affect Istio users.

Backfill after Shriram left to avoid bus factor of only having 3 of us
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Nov 13, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 13, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2020
@linsun
Copy link
Member

linsun commented Nov 17, 2020

I'm good with @nmittler!

@nrjpoddar do you want to be added also?

@howardjohn
Copy link
Member Author

👍 for @nrjpoddar if you are interested. Basically its just approving top level files like readme, go.mod, or files that we didn't add owners for

@nrjpoddar
Copy link
Member

Thanks, you can leave me out for now. 4 is a good number. If you fall short then I'm happy to be included.

Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM @nrjpoddar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants