-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up istio/istio to f527312d926e2a36b94fd1bb4bf72ef27ffda781. #506
Conversation
Signed-off-by: Morlay <[email protected]>
…stio#29150) * Add a type ConfigSourceScheme to avoid hard code * Delete config-source-scheme.yaml Co-authored-by: John Howard <[email protected]>
* Attempt to turn off 10s reachability sleep * remove todo
* Trace istio deploy/teardown in trace.yaml * consistent format * Fix typo
* Pass JSON log encoding to envoy logs Fixes istio#28066 * fix lint
* Remove dead SDS debug code This is obsolete with istio-agent SDS, we now have metrics integrated into agent, and debug integrated in istioctl. This code was never used. * Extend SDS protocol testing This copies over the tests we have for ADS in Istiod to SDS. This ensures we have some extra coverage, and any refactoring is covered here by generic code * Add more tests
istio#29147) * init k8s config store when pilot integrate mock registry in k8s environment. * Fix lint.
…29164) * merge labels and annotations from workloadgroup.sepc.metadata * fix lint * nil checks * imports * more nil checks
Signed-off-by: shaoy <[email protected]>
* display use of bug-report command * exit 1
* consolidate k8s registry bootstrap * start cert patch later * just copy opts struct * debug log * split cert patch from ns controller init * err when main cluster init fails * delay secretcontroller start * only init one workloadentry handler * move ns controller init and add leaderelect in centralistiod mode * nil check * init ca sooner * background leader elect * additional cleanups * debug log * delay start of kube controller to avoid running twice * delay secretcontroller start * lint * make ut pass
…s log (istio#27903) * rebase on master * add test and release note
* properly use cluster id and provider id * fix cross-test pollution * check for non kube * use k8s for fake multicluster test
…#29193) * Fix bug: delegate vs change could not trigger push to sidecars * Fix comments * add test * update * fix lint * lint
Signed-off-by: huabing zhao <[email protected]> Co-authored-by: huabing zhao <[email protected]>
* pkg/queue: optimize the delay queue and resolve some TODOs * pkg/queue: add unit test for capacity shrinking
* Fix fsnotify * go mod update
…stio#29245) * pilot/xds: replace mutex with atomic.Bool when accessing cache sync * Fix the leftover code
* istio-agent/health: reuse the HTTP client of prober * Fix the missing assignment of cfg
* Remove unused helm makefile * Fix makefile
Race 1: simple data race, add proper RLock since we mutate these variables (with Lock()) Race 2: Run() is called in a goroutine. This means we may start doing things before Run() actually happens. HasSynced can pass without Run() being called, so the issue that arises is that reloadNetworkLookup doesn't run, and multinetwork gives unexpected results. This is trivially reproducible with a sleep(1s) in start of Run(). This was tested (along with some other fixes I am working on) by running TestMeshNetworking 10k times over 1hr and getting 0 failures.
* Reorder the server start and the waitCacheSync * restore checking server ready in stream handler
Tested with `7397 runs so far, 0 failures (100.00% pass rate). 258.117472ms avg, 570.8326ms max, 35.770251ms min`
* Update various golang dependencies * gen
* Add values.yaml option for a custom injection template Part of https://docs.google.com/document/d/1Rmp9B3DDypgMCau-YAqidx_r3qvKLZj6jUX-t22zj84/edit * Expand test
Signed-off-by: Kailun Qin <[email protected]>
* Fix race conditions in multinetwork Race 1: simple data race, add proper RLock since we mutate these variables (with Lock()) Race 2: Run() is called in a goroutine. This means we may start doing things before Run() actually happens. HasSynced can pass without Run() being called, so the issue that arises is that reloadNetworkLookup doesn't run, and multinetwork gives unexpected results. This is trivially reproducible with a sleep(1s) in start of Run(). This was tested (along with some other fixes I am working on) by running TestMeshNetworking 10k times over 1hr and getting 0 failures. (cherry picked from commit 7edc7c6) * Fix various push context initialization races * Fixes
The issue here is we add the nodes to our fake informer but not to the fake client, so if the informer updates it breaks the test. This means we are actually only passing when the informer is empty. The real logic in the CNI code is also highly suspicious, I am pretty sure RegisterTaints will always return 0 nodes since we have the same issue of not loading the informer first. However, I am focusing only on fixing the tests right now. `9502 runs so far, 0 failures (100.00% pass rate). 106.009871ms avg, 215.807378ms max, 61.498086ms min` u
I am not sure why it works in the CI, but on my machine any VM image I build is broken since the certs are not readable. This fixes the issue.
* Add regression testing for fuzzers * fix lint * make lint happy
@arkodg Mind approve this? So that I can settle the other PR reference the updated commit id generated from this PR. Also I think we should use non squash merge for this to preserve the commit history, right? |
no merge conflicts 🤔 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
For future reference, I ended up using |
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.