Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link of Mesh dashboard services #29237

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Conversation

carolynhu
Copy link
Contributor

@carolynhu carolynhu commented Nov 28, 2020

Please provide a description for what this PR is for. #29138

Tthe link is pointing to corresponding service now.
Screen Shot 2020-11-27 at 9 22 30 PM

https://snapshot.raintank.io/dashboard/snapshot/q7nLFxxgm3KVd4zpxrr16DzrLTzRYlWF

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x ] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any changes that may affect Istio users.

@carolynhu carolynhu requested review from a team as code owners November 28, 2020 05:17
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 28, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2020
@carolynhu carolynhu added release-notes-none Indicates a PR that does not require release notes. cherrypick/release-1.8 labels Nov 28, 2020
@carolynhu
Copy link
Contributor Author

/retest

@istio-testing istio-testing merged commit 7febdcc into master Nov 28, 2020
@istio-testing istio-testing deleted the mesh_dashboard_fix branch November 28, 2020 14:08
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: #29237 failed to apply on top of branch "release-1.8":

Applying: Fix broken link of Mesh dashboard services
Using index info to reconstruct a base tree...
M	manifests/addons/dashboards/istio-mesh-dashboard.json
M	samples/addons/grafana.yaml
Falling back to patching base and 3-way merge...
Auto-merging samples/addons/grafana.yaml
CONFLICT (content): Merge conflict in samples/addons/grafana.yaml
Auto-merging manifests/addons/dashboards/istio-mesh-dashboard.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix broken link of Mesh dashboard services
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #29241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user experience cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants