Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl workload cmd: escape quotes for bash vars in cluster.env #29452

Merged
merged 5 commits into from
Dec 7, 2020
Merged

istioctl workload cmd: escape quotes for bash vars in cluster.env #29452

merged 5 commits into from
Dec 7, 2020

Conversation

stevenctl
Copy link
Contributor

fixes #29450

~/g/s/i/istio ❯❯❯ source istioctl/cmd/testdata/vmconfig/simple/cluster.env.golden
~/g/s/i/istio ❯❯❯ echo $ISTIO_METAJSON_LABELS | jq
{
  "service.istio.io/canonical-name": "foo",
  "service.istio.io/canonical-version": "latest"
}

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 7, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2020
@stevenctl stevenctl added release-notes-none Indicates a PR that does not require release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2020
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2020
@istio-testing istio-testing merged commit 617ab23 into istio:master Dec 7, 2020
stevenctl added a commit to stevenctl/istio that referenced this pull request Dec 7, 2020
@stevenctl
istioctl workload cmd: escape quotes for bash vars in cluster.env (is…
ca8235c 
…tio#29452)

* istioctl workload cmd: escape quotes for bash vars in cluster.env

* banner

* regexp in raw string

* update golden

* fix imports

(cherry picked from commit 617ab23)
istio-testing pushed a commit that referenced this pull request Dec 7, 2020
@stevenctl
istioctl workload: put proxyConfig.proxyMetadata in cluster.env (#29393…
806fb24 
…) (#29449)

* istioctl workload: put proxyConfig.proxyMetadata in cluster.env (#29393)

* istioctl workload: put proxyConfig.proxyMetadata in cluster.env

* add unit testing

* remove hack from echo vms

* cluster.env has trailing newline

* newline

* respect echoCfg.VMEnvironment

(cherry picked from commit b1db279)

* istioctl workload cmd: escape quotes for bash vars in cluster.env (#29452)

* istioctl workload cmd: escape quotes for bash vars in cluster.env

* banner

* regexp in raw string

* update golden

* fix imports

(cherry picked from commit 617ab23)
@incfly incfly mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esnible esnible esnible approved these changes

@howardjohn howardjohn howardjohn approved these changes

@costinm costinm Awaiting requested review from costinm

@linsun linsun Awaiting requested review from linsun

@nmittler nmittler Awaiting requested review from nmittler

Assignees

@howardjohn howardjohn

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster.env escaping isn't correct for VM labels
4 participants
@stevenctl @howardjohn @esnible @istio-testing