Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove port 15053 from discover deployment #29579

Merged
merged 1 commit into from
Dec 12, 2020
Merged

remove port 15053 from discover deployment #29579

merged 1 commit into from
Dec 12, 2020

Conversation

rinormaloku
Copy link
Contributor

@rinormaloku rinormaloku commented Dec 11, 2020 •
edited
Loading

Removing port 15053 from the deployments and services of the Istio Pilot

Resolves #29578

@rinormaloku rinormaloku requested review from a team as code owners December 11, 2020 12:39
@istio-policy-bot
Copy link

😊 Welcome @rinormaloku! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 11, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2020
@istio-testing
Copy link
Collaborator

Hi @rinormaloku. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rinormaloku rinormaloku changed the title removed port 15053 from discover deployment remove port 15053 from discover deployment Dec 11, 2020
@howardjohn
Copy link
Member

/ok-to-test

thanks!

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 11, 2020
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Dec 11, 2020
@howardjohn
Copy link
Member

/retest

2 similar comments
@howardjohn
Copy link
Member

/retest

@rinormaloku
Copy link
Contributor Author

/retest

@istio-testing istio-testing merged commit 8933f45 into istio:master Dec 12, 2020
Laci21 added a commit to banzaicloud/istio-operator that referenced this pull request Feb 3, 2021
@Laci21
Remove port 15053 from istiod deployment
4900405 
See: istio/istio#29579
Laci21 added a commit to banzaicloud/istio-operator that referenced this pull request Feb 4, 2021
@Laci21
Remove port 15053 from istiod deployment
2de1ce7 
See: istio/istio#29579
Laci21 added a commit to banzaicloud/istio-operator that referenced this pull request Feb 5, 2021
@Laci21
Remove port 15053 from istiod deployment
3b14030 
See: istio/istio#29579
@incfly incfly mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleanup yaml/manifests exposing port 15053 for Istiod
4 participants
@rinormaloku @istio-policy-bot @istio-testing @howardjohn