Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-started: update sample commands using dataset-registry repo; other related changes #585

Merged
merged 33 commits into from
Sep 18, 2019
Merged

get-started: update sample commands using dataset-registry repo; other related changes #585

merged 33 commits into from
Sep 18, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@shcheklein shcheklein temporarily deployed to dvc-org-pr-585 August 23, 2019 22:26 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 23, 2019 22:35 Inactive
@jorgeorpinel jorgeorpinel changed the title get-started: update commands given new dataset-registry repo get-started: update commands given new dataset-registry repo [WIP] Aug 23, 2019
@jorgeorpinel

This comment has been minimized.

Sign in to view
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 24, 2019 19:42 Inactive
@jorgeorpinel jorgeorpinel force-pushed the jorgeorpinel--dataset-registry branch from 88b23e0 to 3b3a92f Compare August 24, 2019 19:46
@jorgeorpinel jorgeorpinel changed the title get-started: update commands given new dataset-registry repo [WIP] get-started: update commands given new dataset-registry repo Aug 24, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 24, 2019 19:46 Inactive
@jorgeorpinel

This comment has been minimized.

Sign in to view
shcheklein
shcheklein reviewed Aug 25, 2019
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
shcheklein
shcheklein requested changes Aug 25, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start. Please, check the comments to address.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 26, 2019 21:07 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 26, 2019
Merged
jorgeorpinel added a commit that referenced this pull request Aug 26, 2019
@jorgeorpinel
get-started: add data-artifacts chapter
1d449d0 
per #585 (comment)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 26, 2019 22:56 Inactive
@jorgeorpinel jorgeorpinel force-pushed the jorgeorpinel--dataset-registry branch from 1d449d0 to 6aba9c4 Compare August 26, 2019 23:01
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-585 August 26, 2019 23:01 Inactive
@iAdramelk iAdramelk mentioned this pull request Aug 27, 2019
Closed
@jorgeorpinel

This comment has been minimized.

Sign in to view
shcheklein
shcheklein requested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, take a look at my responses and a few comments I left

@jorgeorpinel jorgeorpinel mentioned this pull request Sep 14, 2019
Merged
@jorgeorpinel jorgeorpinel force-pushed the jorgeorpinel--dataset-registry branch from 8e9e947 to 6fd5104 Compare September 14, 2019 21:16
jorgeorpinel referenced this pull request Sep 17, 2019
@jorgeorpinel
get: add example about checking out different artifact versions
8e9e947 
per #611 (comment)
but for #487
shcheklein
shcheklein approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 :)

@shcheklein shcheklein merged commit 4e26869 into master Sep 18, 2019
@shcheklein shcheklein deleted the jorgeorpinel--dataset-registry branch October 22, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

@iAdramelk iAdramelk iAdramelk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @iAdramelk @shcheklein