Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Supporting the same variables as the java bindings would be helpful #206

Closed
9 tasks
rbtcollins opened this issue Oct 2, 2017 · 3 comments
Closed
9 tasks

Supporting the same variables as the java bindings would be helpful #206

rbtcollins opened this issue Oct 2, 2017 · 3 comments
Labels
help wanted

Comments

@rbtcollins
Copy link

rbtcollins commented Oct 2, 2017 •
edited
Loading

Specifically https://github.com/uber/jaeger-client-java/blob/master/jaeger-core/README.md#configuration-via-environment

  • JAEGER_AGENT_HOST
  • JAEGER_AGENT_PORT
  • JAEGER_REPORTER_LOG_SPANS
  • JAEGER_REPORTER_MAX_QUEUE_SIZE
  • JAEGER_REPORTER_FLUSH_INTERVAL
  • JAEGER_SAMPLER_TYPE
  • JAEGER_SAMPLER_PARAM
  • JAEGER_SAMPLER_MANAGER_HOST_PORT
  • JAEGER_TAGS
rbtcollins pushed a commit to rbtcollins/jaeger-client-go that referenced this issue Oct 5, 2017
Support JAEGER_AGENT_HOST/PORT variables
2ed1651 
This makes it much easier to support different deployment strategies
for the agent. Partial support for jaegertracing#206.

Signed-off-by: Robert Collins <[email protected]>
This was referenced Oct 5, 2017
Closed
Merged
@ishanjain28
Copy link

Hey @rbtcollins I am interested in working on this. Should I start adding support for remaining variables in your fork?

rbtcollins pushed a commit to rbtcollins/jaeger-client-go that referenced this issue Oct 31, 2017
Support JAEGER_AGENT_HOST/PORT variables
9392cab 
This makes it much easier to support different deployment strategies
for the agent. Partial support for jaegertracing#206.

Signed-off-by: Robert Collins <[email protected]>
@jpkrohling
Copy link
Contributor

I just started working on this.

@rbtcollins
Copy link
Author

Please do take it over - I've just been super busy and am happy for someone else to do it :)

jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 27, 2018
@jpkrohling
Closes jaegertracing#206 - Added support for client configuration via…
bdbd31e 
… env vars

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 28, 2018
@jpkrohling
Closes jaegertracing#206 - Added support for client configuration via…
5f6d850 
… env vars

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@yurishkuro yurishkuro mentioned this issue Mar 28, 2018
Merged
20 tasks
jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 28, 2018
@jpkrohling
Added support for client configuration via env vars
c844e00 
Adds support for configuring the tracer based on environment variables,
similar to what is currently supported by the Java client.

Closes jaegertracing#206

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 28, 2018
@jpkrohling
Added support for client configuration via env vars
7fe69a0 
Adds support for configuring the tracer based on environment variables,
similar to what is currently supported by the Java client.

Closes jaegertracing#206

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 29, 2018
@jpkrohling
Added support for client configuration via env vars
b255cfa 
Adds support for configuring the tracer based on environment variables,
similar to what is currently supported by the Java client.

Closes jaegertracing#206

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/jaeger-client-go that referenced this issue Mar 30, 2018
@jpkrohling
Added support for client configuration via env vars
2dd39a3 
Adds support for configuring the tracer based on environment variables,
similar to what is currently supported by the Java client.

Closes jaegertracing#206

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
black-adder pushed a commit that referenced this issue Apr 3, 2018
@jpkrohling @black-adder
Added support for client configuration via env vars (#275)
6cc524e 
Adds support for configuring the tracer based on environment variables,
similar to what is currently supported by the Java client.

Closes #206

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpkrohling @rbtcollins @black-adder @ishanjain28