Trace the dedicated query server #454
Conversation
rbtcollins
requested review from
black-adder,
pavolloffay,
vprithvi and
yurishkuro
as code owners
The standalone query server already has tracing enabled. This is a trivial parity patch. Signed-off-by: Robert Collins <[email protected]>
| @@ -65,6 +66,18 @@ func main() { | |||
|
|
|||
| metricsFactory := xkit.Wrap("jaeger-query", expvar.NewFactory(10)) | |||
|
|
|||
| tracer, closer, err := jaegerClientConfig.Configuration{ | |||
| Sampler: &jaegerClientConfig.SamplerConfig{ | |||
| Type: "probabilistic", | |||
There was a problem hiding this comment.
use const instead of probabilistic, it's cheaper.
There was a problem hiding this comment.
actually, I think this needs to be overridable vie cmd line switches
There was a problem hiding this comment.
This will be via jaegertracing/jaeger-client-go#206 no? I think we should have one set of variables for all the Jaeger bindings, so that its really easy to configure jaeger enabled components in one consistent fashion. That hasn't been done yet though.
I can switch this to const easily - I think its worth noting though that this is the code thats in the all-in-one entry point. Should I change that at the same time?
Given that this is a very simple and relatively low-use UI: scales O(developers) not O(users), I think a const of 1 is fine to start with.
The standalone query server already has tracing enabled. This is a trivial parity patch. Signed-off-by: Robert Collins <[email protected]>
The standalone query server already has tracing enabled. This is a trivial parity patch. Signed-off-by: Robert Collins <[email protected]>
The standalone query server already has tracing enabled. This is a
trivial parity patch.