Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tests for the examples #582

Merged
merged 6 commits into from
Aug 9, 2019
Merged

Initial tests for the examples #582

merged 6 commits into from
Aug 9, 2019

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls [email protected]

This is the initial set of tests for #144 It covers everything but:

all-in-one-with-options.yaml
business-application-injected-sidecar.yaml
custom-serviceaccount.yaml
disable-ingress.yaml
openshift/custom-sar-oauth-proxy.yaml
openshift/disable-oauth-proxy.yaml
openshift/with-httpasswd.yaml

Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
@kevinearls
Copy link
Contributor Author

@pavolloffay @objectiser @jpkrohling Please review. This is the initial set of tests, I will add more when I have a bit more free time. I setup the tests to run on Travis, but at the moment they take quite a bit longer than the next slowest set of tests (16:46 v. 12:30 for cassandra tests.) Do you think we need to run these on a per PR basis?

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d47a4d4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #582   +/-   ##
=========================================
  Coverage          ?   91.27%           
=========================================
  Files             ?       73           
  Lines             ?     3655           
  Branches          ?        0           
=========================================
  Hits              ?     3336           
  Misses            ?      227           
  Partials          ?       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47a4d4...7cd216d. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d47a4d4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #582   +/-   ##
=========================================
  Coverage          ?   91.27%           
=========================================
  Files             ?       73           
  Lines             ?     3655           
  Branches          ?        0           
=========================================
  Hits              ?     3336           
  Misses            ?      227           
  Partials          ?       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47a4d4...31a3e1e. Read the comment docs.

Signed-off-by: Kevin Earls <[email protected]>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinearls
Copy link
Contributor Author

@jpkrohling can you merge this, as Gary is out?

@jpkrohling jpkrohling merged commit c367de1 into jaegertracing:master Aug 9, 2019
@kevinearls kevinearls deleted the add-test-for-examples branch August 9, 2019 09:07
@pavolloffay
Copy link
Member

in #587 I had to restart travis job for examples as it failed.

@kevinearls kevinearls mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants