-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial tests for the examples #582
Initial tests for the examples #582
Conversation
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
@pavolloffay @objectiser @jpkrohling Please review. This is the initial set of tests, I will add more when I have a bit more free time. I setup the tests to run on Travis, but at the moment they take quite a bit longer than the next slowest set of tests (16:46 v. 12:30 for cassandra tests.) Do you think we need to run these on a per PR basis? |
Signed-off-by: Kevin Earls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=========================================
Coverage ? 91.27%
=========================================
Files ? 73
Lines ? 3655
Branches ? 0
=========================================
Hits ? 3336
Misses ? 227
Partials ? 92 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=========================================
Coverage ? 91.27%
=========================================
Files ? 73
Lines ? 3655
Branches ? 0
=========================================
Hits ? 3336
Misses ? 227
Partials ? 92 Continue to review full report at Codecov.
|
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jpkrohling can you merge this, as Gary is out? |
in #587 I had to restart travis job for examples as it failed. |
Signed-off-by: Kevin Earls [email protected]
This is the initial set of tests for #144 It covers everything but:
all-in-one-with-options.yaml
business-application-injected-sidecar.yaml
custom-serviceaccount.yaml
disable-ingress.yaml
openshift/custom-sar-oauth-proxy.yaml
openshift/disable-oauth-proxy.yaml
openshift/with-httpasswd.yaml