Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure index cleaner properly when rollover is enabled #587

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

pavolloffay
Copy link
Member

Resolves #547

Signed-off-by: Pavol Loffay [email protected]

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #587 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   91.27%   91.27%   +<.01%     
==========================================
  Files          73       73              
  Lines        3655     3658       +3     
==========================================
+ Hits         3336     3339       +3     
  Misses        227      227              
  Partials       92       92
Impacted Files Coverage Δ
pkg/cronjob/es_index_cleaner.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c367de1...4928c2e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #587 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   91.27%   91.27%   +<.01%     
==========================================
  Files          73       73              
  Lines        3655     3658       +3     
==========================================
+ Hits         3336     3339       +3     
  Misses        227      227              
  Partials       92       92
Impacted Files Coverage Δ
pkg/cronjob/es_index_cleaner.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c367de1...4928c2e. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just double check the env var before merging, I had the impression we used ES_ROLLOVER instead of ROLLOVER

@pavolloffay
Copy link
Member Author

There is no ES_ROLLOVER anywhere. It's only ROLLOVER as those scripts work only for ES https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/es/esCleaner.py#L19

@pavolloffay pavolloffay merged commit cbb3610 into jaegertracing:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly configure index cleaner when rollover is enabled
2 participants