New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying the document #299

Merged

MykolaSopiha merged 222 commits into javascript-tutorial:master from malechaneit:modifying-the-document

Feb 17, 2022

Contributor

malechaneit commented Jan 27, 2022

Перекладено все, включаючи завдання та текст для svg. Але новий файл before-prepend-append-after.svg не змогла згенерувати (помилки в консолі)

javascript-translate-bot added the review needed label

CLAassistant commented Jan 27, 2022 •

edited

Loading

All committers have signed the CLA.

javascript-translate-bot mentioned this pull request

Ukrainian Translation Progress #1

Open

Collaborator

dolgachio commented Jan 28, 2022

@malechaneit дякуємо за переклад! Щоб ми змогли його прийняти, будь ласка, підпишіть Contributor License Agreement. Там є повідомлення від бота:

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

MykolaSopiha requested changes

View reviewed changes

2-ui/1-document/07-modifying-document/4-clear-elem/solution.md Show resolved Hide resolved

2-ui/1-document/07-modifying-document/4-clear-elem/task.md Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/6-create-list/solution.view/index.html Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/7-create-object-tree/build-tree-dom.view/index.html Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/7-create-object-tree/build-tree-dom.view/index.html Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/9-calendar-table/solution.view/index.html Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

javascript-translate-bot added changes requested and removed review needed labels

Contributor

javascript-translate-bot commented Jan 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha added the partially reviewed label

MykolaSopiha requested changes

View reviewed changes

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

Contributor

javascript-translate-bot commented Jan 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha requested changes

View reviewed changes

2-ui/1-document/07-modifying-document/article.md Outdated Show resolved Hide resolved

Contributor

javascript-translate-bot commented Jan 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha requested changes

View reviewed changes

2-ui/1-document/07-modifying-document/article.md Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Show resolved Hide resolved

2-ui/1-document/07-modifying-document/article.md Show resolved Hide resolved

Contributor

javascript-translate-bot commented Jan 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha requested changes

View reviewed changes

2-ui/1-document/07-modifying-document/article.md Show resolved Hide resolved

Contributor

javascript-translate-bot commented Jan 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Contributor Author

malechaneit commented Jan 31, 2022

@malechaneit дякуємо за переклад! Щоб ми змогли його прийняти, будь ласка, підпишіть Contributor License Agreement. Там є повідомлення від бота:
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

Підписала від імені @malechaneit, а от як це зробити від Vita Chukhno не розумію.

Collaborator

dolgachio commented Jan 31, 2022

@malechaneit судячи з всього, вам потрібно додати email, який ви використовували для цього комміту (Vita Chukhno) до свого аккаунту в ГітХаб.

Contributor Author

malechaneit commented Jan 31, 2022

@malechaneit судячи з всього, вам потрібно додати email, який ви використовували для цього комміту (Vita Chukhno) до свого аккаунту в ГітХаб.

Так, вже зробила. Але попередні коміти так і залишаться без мейлу, якщо не відредагувати інформацію про автора в конкретному коміті. Без підпису Vita Chukhno мердж буде неможливий?

malechaneit and others added 10 commits

February 2, 2022 16:42


          Modifying document. Article and tasks

0eb4c7a


          TextDecoder and TextEncoder (javascript-tutorial#256)

1faa065


          Update article.md

3a1f194

ms - official international name for millisecond. 1 ms = 1 * 10**(-3) second (or 1e-3). Source : https://en.wikipedia.org/wiki/Metric_prefix .
0.000001 or 1e-6 - it's microsecond. Better name for this variable 'mcs' or 'us'. 'mcs' easier to understand.


          Promises chaining (javascript-tutorial#259)

a0446e4


          Basic DOM Node Properties (javascript-tutorial#260)


          Event delegation (javascript-tutorial#262)

b158d36


          Reorder contributors arrording translated articles

e01fa05


          Remove contributor

6cfed1b


          docs: add OlhaBrozhenets as a contributor for translation (javascript…

dc40bf6

…-tutorial#263)


          Browser default actions (javascript-tutorial#264)

1093b2c

MykolaSopiha added 10 commits

February 17, 2022 01:56


          Update 1-js/11-async/03-promise-chaining/article.md

7566d99


          Update 2-ui/1-document/07-modifying-document/4-clear-elem/solution.md

4a40c11


          Update 2-ui/1-document/05-basic-dom-node-properties/article.md

70b3d16


          Update 2-ui/2-events/04-default-browser-action/article.md

dd1986a


          Update 2-ui/1-document/07-modifying-document/article.md

80b7a0f


          Update 2-ui/1-document/07-modifying-document/article.md

ce9d75f


          Update 2-ui/1-document/07-modifying-document/article.md

397cf86


          Update 2-ui/1-document/07-modifying-document/article.md

98da301


          Update 2-ui/1-document/07-modifying-document/article.md

dd50836


          Update 2-ui/1-document/07-modifying-document/article.md

2105a33

MykolaSopiha approved these changes

View reviewed changes

1-js/02-first-steps/02-structure/article.md Outdated Show resolved Hide resolved

MykolaSopiha added 17 commits

February 17, 2022 02:15


          Update 1-js/02-first-steps/02-structure/article.md

6513f2b


          Update 2-ui/1-document/07-modifying-document/article.md

824f4d7


          Update 2-ui/1-document/07-modifying-document/article.md

85fd950


          Update 2-ui/1-document/07-modifying-document/article.md

e2c2ef3


          Update 2-ui/2-events/04-default-browser-action/article.md

b471499


          Update 2-ui/1-document/07-modifying-document/article.md

568eb42


          Update 2-ui/1-document/07-modifying-document/article.md

60bce46


          Update 2-ui/2-events/04-default-browser-action/article.md

f291b4b


          Update 2-ui/2-events/04-default-browser-action/article.md

3a1a92d


          Update 2-ui/2-events/04-default-browser-action/article.md

959eeb2


          Update 2-ui/2-events/04-default-browser-action/article.md

dc370e6


          Update 2-ui/2-events/04-default-browser-action/article.md

31bae74


          Update 2-ui/1-document/07-modifying-document/article.md

da695ee


          Update 2-ui/1-document/07-modifying-document/article.md

a261124


          Update 2-ui/1-document/07-modifying-document/article.md

96d5a6d


          Update 2-ui/1-document/07-modifying-document/article.md

6abf32d


          Merge branch 'master' into modifying-the-document

28d5015

MykolaSopiha merged commit 8054efd into javascript-tutorial:master

Contributor

javascript-translate-bot commented Feb 17, 2022

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 partially reviewed