Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomness-altering Threefry RNG upgrade #13346

Open
froystig opened this issue Nov 22, 2022 · 1 comment
Open

randomness-altering Threefry RNG upgrade #13346

froystig opened this issue Nov 22, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@froystig
Copy link
Member

froystig commented Nov 22, 2022

Tracking issue for upgrading through breaking changes to the Threefry PRNG implementation. Specifically, these changes alter the pseudorandom bits produced by a given key, relative to the current implementation. The upgrade at least includes #13040 (superseding #13012) and #13341, which are currently guarded by jax.config.jax_threefry_partitionable.

It may be convenient to offer backwards opt-in in the form of a PRNG implementation "snapshot" of Threefry, since all changes sit behind the PRNG interface (see #6899).

We can close this issue when the upgrade is complete, in that the new Threefry implementation is on by default.

@jakevdp
Copy link
Collaborator

jakevdp commented Nov 28, 2022

I'd like the changes in #12539 to be part of this as well, under whatever flag is appropriate. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants