Create jax_random_future flag & make jax.random.loggamma more robust #12539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froystig
reviewed
Sep 28, 2022
jakevdp
force-pushed
the
random-future
branch
from
e275440 to
ef87aec
Compare
Done |
|
Replaced by #16779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing TODO regarding the implementation of
random.loggamma; technically this is a breaking change as it changes the stream of random values that are produced. For this reason, I put the changes behind ajax_random_futureflag, as suggested by @froystig to align these changes with other upcoming changes tojax.random.