Revision edits #238
Revision edits #238
Conversation
|
AppVeyor build 1.0.667 for commit 9760283 is now complete.... Found 9 potential spelling error(s). Preview:content/02.intro.md:17:TODOcontent/03.combining-datasets.md:7:hoc content/03.combining-datasets.md:13:ontologies content/10. figure_legends.md:3:Barplot content/12. box_2_definitions.md:7:undirected content/12. box_2_definitions.md:24:ImageNet content/13. box_3_MLtasks.md:12:subtyping content/13. box_3_MLtasks.md:13:heterogenous content/13. box_3_MLtasks.md:16:subpopulations The rendered manuscript from this build is temporarily available for download at: |
|
AppVeyor build 1.0.669 for commit e3ca523 is now complete. Found 12 potential spelling error(s). Preview:content/02.intro.md:17:TODOcontent/03.combining-datasets.md:7:hoc content/03.combining-datasets.md:13:ontologies content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirected content/15. box_2_definitions.md:24:ImageNet content/16. box_3_MLtasks.md:12:subtyping cont... |
|
AppVeyor build 1.0.671 for commit bd5ccef is now complete. Found 11 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirected content/15. box_2_definitions.md:24:ImageNet content/16. box_3_MLtasks.md:12:subtyping content/16. box_3_MLtasks.md:13:... |
port edits from RJA
|
@jaclyn-taroni please do your review/edits on this PR |
|
AppVeyor build 1.0.672 for commit 6a260ad is now complete. Found 14 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/05.model-complexity.md:32:ALS content/05.model-complexity.md:32:amyotrophic content/05.model-complexity.md:33:ALS content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirect... |
Per reviewer comment
Per reviewer comment
Per reviewer comment
There was a problem hiding this comment.
Returning a comment I had here. I also wanted to ask – @jaybee84 would you be able to summarize how you picked what went into Box 3? I know we discussed using what is in the manuscript to guide what tasks to include. What I'm trying to understand: are the tasks that got picked and where they are referenced in the text are related to citations of specific studies? I.e., if you're referencing diagnostic decision support in the main text – "(Box 3a"), is that because one of the studies cited in that passage fit that bill? Asking to focus my review/edits 😸
@jaclyn-taroni This is exactly the case. |
|
@jaclyn-taroni I realize now that I responded to only half your comment above: The main way I arrived at the content of the box was by reviewing the main citations to see what were the major tasks those papers were referring to. Box 3a-d are cited in the sections that had references to papers which intended to do those tasks. Box 3e is the only one which is not referenced in our sections, but I added this due to my prior knowledge about a recent paper in neurofibromatosis which is partially focused on this problem. |
|
👍🏻 keeping this in mind as I review where the references to Box 3 are inserted and how the tasks are defined (in progress) |
|
@jaclyn-taroni Thanks! If you get the chance to cut some words, that would be great too. We are currently over the word limit. I am also planning to do word count edit once your PR is in. |
|
@jaclyn-taroni @allaway our one week extension request was accepted. @jaclyn-taroni I am hoping to send the updated manuscript to Casey and Justin by Feb 22 (wed) so that they have one week to review before our submission deadline is up. Please let me know if this timeline sounds ok, or if I can help in any way to keep us on track with the timeline :) |
|
@jaybee84 Do you want to update the LASSO reference I added as a TODO in my branch here? That also extends to anything else that was edited in the Word doc but didn't get added here that I missed. I am aiming to wrap up my edits today and potentially address #234 (but I think we can all work on #234 in parallel). |
…-box-order Change box order, make diagnostic decision support more general
-added
WIP |
Co-authored-by: Jineta Banerjee <[email protected]>
|
AppVeyor build 1.0.675 for commit e39e8f7 is now complete. Found 14 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/05.model-complexity.md:32:ALS content/05.model-complexity.md:32:amyotrophic content/05.model-complexity.md:33:ALS content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirect... |
|
AppVeyor build 1.0.676 for commit b34f139 is now complete. Found 14 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/05.model-complexity.md:32:ALS content/05.model-complexity.md:32:amyotrophic content/05.model-complexity.md:33:ALS content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirect... |
|
AppVeyor build 1.0.677 for commit 2cb9bc4 is now complete. Found 14 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/05.model-complexity.md:32:ALS content/05.model-complexity.md:32:amyotrophic content/05.model-complexity.md:33:ALS content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/15. box_2_definitions.md:7:undirect... |
@jaclyn-taroni between your edits on #242 and my latest updates I think we have everything covered. |
Co-authored-by: Jineta Banerjee <[email protected]>
Jaclyn taroni/2023 02 19 edits
|
AppVeyor build 1.0.679 for commit c26f741 is now complete. Found 14 potential spelling error(s). Preview:content/03.combining-datasets.md:7:hoccontent/03.combining-datasets.md:13:ontologies content/05.model-complexity.md:32:ALS content/05.model-complexity.md:32:amyotrophic content/05.model-complexity.md:33:ALS content/09. ethics_declaration.md:3:Tempus content/11. author_contributions.md:3:ICMJE content/11. author_contributions.md:5:curation content/13. figure_legends.md:3:Barplot content/14. box_1_MLtasks.md:21:subtyping c... |
[ci skip] This build is based on 97ccacc. This commit was created by the following CI build and job: https://github.com/jaybee84/ml-in-rd/commit/97ccacc5fcfb5f701fb714515a888618779ba929/checks https://github.com/jaybee84/ml-in-rd/runs/4237850017
[ci skip] This build is based on 97ccacc. This commit was created by the following CI build and job: https://github.com/jaybee84/ml-in-rd/commit/97ccacc5fcfb5f701fb714515a888618779ba929/checks https://github.com/jaybee84/ml-in-rd/runs/4237850017
Purpose
Resolves #231 , #232 , #232
Directions for reviewers
HI All, I have ported all recent edits to GH from the word doc. Please review all changes and check if they address reviewer comments. No need to edit the word doc anymore. I was able to build the docx version locally and will be happy to do the track changes once we have finalized all edits.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the pull request ready for review?
YES
Manuscript checklist
Unless otherwise noted above, this PR will be considered ready for review when all four items have been checked.