-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaclyn taroni/2023 02 19 edits #242
Jaclyn taroni/2023 02 19 edits #242
Conversation
Per reviewer comment
Per reviewer comment
Per reviewer comment
@jaclyn-taroni Thanks for starting this draft. I was just taking a look at the changes, and it looks like a bunch of changes that I had already made in the original (word doc) did not port correctly to the PR .. e.g.
Thanks for going through those and fixing/updating those. Looking forward to your finalized changes. |
I'm going to mark this ready for review for the benefit of running the other checks. Edit: That's not the issue, it's that I'm targeting a branch other than the default branch. |
…-box-order Change box order, make diagnostic decision support more general
Okay, with c03e152, I made a few tweaks to where the new box (Box 1) is referenced. Some references seemed too low context given what the sentenced around them actually said – a reader is unlikely to be familiar with the papers cited – so I've either removed something or made it clear it was an example by adding |
Co-authored-by: Jineta Banerjee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor comments. otherwise look good to me..
@jaclyn-taroni I see that you did not make any changes to the |
Co-authored-by: Jineta Banerjee <[email protected]>
Yes, no additional edits. |
Stacked on #238
Summarizing changes:
I'd like to take another look at Box 3 tomorrow, so I'm marking as a draft for now.