-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): menu-item 组件增加标题icon自定义方式 #2488
Conversation
Warning Rate limit exceeded@Alex-huxiyang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 49 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Walkthrough此次更改主要集中在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Menu
participant MenuItem
participant IconRenderer
User->>Menu: 点击菜单项
Menu->>MenuItem: 渲染菜单项
MenuItem->>IconRenderer: 请求图标
IconRenderer-->>MenuItem: 返回 titleIcon 或 默认图标
MenuItem-->>Menu: 显示菜单项
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
可以先解决一下冲突 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2488 +/- ##
==========================================
+ Coverage 83.05% 83.06% +0.01%
==========================================
Files 217 217
Lines 17744 17756 +12
Branches 2549 2552 +3
==========================================
+ Hits 14737 14749 +12
Misses 3002 3002
Partials 5 5 ☔ View full report in Codecov by Sentry. |
🤔 这个变动的性质是?
🔗 相关 Issue
#2487
💡 需求背景和解决方案
titleIcon
用于配置标题 icon☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
titleIcon
属性,允许用户在菜单项旁边显示自定义图标,提升界面清晰度和交互体验。Filter
图标,进一步增强了菜单项的视觉表示。文档
titleIcon
属性的描述,帮助开发者更好地理解和使用该功能。