-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: @nutui/icons-react changed to @nutui/icons-react-taro #2651
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2651 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 217 217
Lines 17827 17827
Branches 2608 2608
=======================================
Hits 14988 14988
Misses 2834 2834
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Walkthrough此次更改涉及 Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -1,6 +1,6 @@ | |||
import React, { useState } from 'react' | |||
import { Cell, Calendar } from '@nutui/nutui-react-taro' | |||
import { Star } from '@nutui/icons-react' | |||
import { Star } from '@nutui/icons-react-taro' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
发现依赖配置问题。
package.json
中同时存在 @nutui/icons-react
和 @nutui/icons-react-taro
依赖,建议移除未使用的 @nutui/icons-react
以保持依赖一致性。
🔗 Analysis chain
导入路径更新正确。
导入语句的更改符合预期,将 Star
图标的来源从 @nutui/icons-react
更新为 @nutui/icons-react-taro
。这与 PR 的目标一致。
运行以下脚本以验证项目中的一致性:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 描述:检查项目中是否还有其他使用 @nutui/icons-react 的地方
# 测试:搜索 @nutui/icons-react 的使用情况。预期:应该没有匹配项。
rg -i '@nutui/icons-react(?!-taro)' --type ts --type tsx
# 测试:检查 package.json 中的依赖。预期:应该使用 @nutui/icons-react-taro。
jq '.dependencies["@nutui/icons-react-taro"]' package.json
jq '.dependencies["@nutui/icons-react"]' package.json
Length of output: 442
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
Demo1
组件中的Star
图标导入路径,以支持 Taro 框架。