Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExoPlayer improvements: Submit playback status via apiclient, support remote seeking and volume changes #104

Merged
merged 1 commit into from
Sep 7, 2020
Merged

ExoPlayer improvements: Submit playback status via apiclient, support remote seeking and volume changes #104

merged 1 commit into from
Sep 7, 2020

Conversation

Maxr1998
Copy link
Member

@Maxr1998 Maxr1998 commented Sep 5, 2020

No description provided.

@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels Sep 5, 2020
@Maxr1998 Maxr1998 force-pushed the apiclient-progress branch 3 times, most recently from cd6e4a0 to 3fdf799 Compare September 5, 2020 22:31
@Maxr1998
Copy link
Member Author

Maxr1998 commented Sep 5, 2020 •
edited
Loading

Just noticed a small issue for playback ending, need to fix that tomorrow.

EDIT: fixed

nielsvanvelzen
nielsvanvelzen requested changes Sep 6, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the WEBAPP_FUNCTION_CHANNEL anymore because playback state is reported via apiclient instead of web?

app/src/main/java/org/jellyfin/mobile/bridge/NativePlayer.kt Outdated Show resolved Hide resolved
app/src/main/java/org/jellyfin/mobile/player/PlayerViewModel.kt Show resolved Hide resolved
app/src/main/java/org/jellyfin/mobile/utils/StdlibExtensions.kt Outdated Show resolved Hide resolved
@Maxr1998
Copy link
Member Author

Maxr1998 commented Sep 6, 2020 •
edited
Loading

We don't need the WEBAPP_FUNCTION_CHANNEL anymore because playback state is reported via apiclient instead of web?

Yes, exactly. Though now that you mention it, I could possibly replace the binder interface from the music player service with it. Maybe I'll add it back then.

EDIT: done.

@Maxr1998
ExoPlayer improvements
d0844d3 
Submit playback status via apiclient, support remote seeking and volume changes
@CarlosOlivo CarlosOlivo mentioned this pull request Sep 7, 2020
Merged
@nielsvanvelzen nielsvanvelzen merged commit a3368fd into master Sep 7, 2020
@nielsvanvelzen nielsvanvelzen deleted the apiclient-progress branch September 7, 2020 08:30
@nielsvanvelzen nielsvanvelzen mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maxr1998 @nielsvanvelzen