-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screen lock feature in ExoPlayer #108
Conversation
About the external player feature, I actually just pushed a PR that moves the external player selection to the native client settings 😅 |
Nice timing. |
Yeah, sorry 🙈 |
9fe532c
to
c659898
Compare
Thanks a lot for the PR, the code looks really good! Spotted some small issues, would appreciate if you could resolve them before merge 😇 |
Well, I can say the same, I started working on this since yesterday and just finish it now, sorry for the spam. |
c659898
to
ce4d2a2
Compare
I don't know if it's an error or WIP, but ExoPlayer now don't report when the playback stops or ends, it keeps reporting "/Sessions /Playing/Progress", in the background, I don't know since when, in the v2.0.0-rc.3 version it works correctly, reporting "/Sessions/Playing/Stopped" at the end. @Maxr1998 @nielsvanvelzen |
That might be a regression of #104. We'll need to look into that. |
Interesting, in my testing it successfully marked the title as played, but that may be because the progress was high enough (you can set in Jellyfin after what percentage played it's considered as watched, after all). I previously thought that the ending submission works by setting the progress to the runtime length, but there seems to be another API route then. I'll investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this another test locally, and merge it afterwards 👍
Thanks again for the PR @CarlosOlivo, looking forward to see more contributions from you in the future! |
Closes #77