Set appMode for webui #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
requested changes
Sep 28, 2020
|
I've noticed this doesn't actually fix chromecast issues but only appeared to do so while testing on one of my devices. Nothing changed on another device I have. But in the end we still need to add the app mode so I'll change the PR title to not say a thing about casting 😂 |
Maxr1998
approved these changes
Sep 29, 2020
|
I just sideloaded this RC7. This merge appears to have borked the server connection process on Pixel 3 running vanilla Android 11. |
|
See #153 (comment) |
|
Oh my, we really need to get rid of the web client and build a native one that we actually control.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webui needs the
appModeproperty set to eithercordovaorandroidfor some behavior. We didn't do that.Relevant code in web: https://github.com/jellyfin/jellyfin-web/blob/692d404285c19e1700a74fec23b4804273d12ac3/src/components/castSenderApi.js#L3
As you can see, if the app mode is not set it will always load the cast_sender JavaScript from Google, this JS would then overwrite our own injected code. By setting the appMode it doesn't do that.
It doesn't fix most chromecast issues though.