Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set appMode for webui" #154

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Revert "Set appMode for webui" #154

merged 1 commit into from
Sep 30, 2020

Conversation

Maxr1998
Copy link
Member

@Maxr1998 Maxr1998 commented Sep 29, 2020 •
edited
Loading

Reverts #146
Closes #153

@Maxr1998 Maxr1998 added the bug Something isn't working label Sep 29, 2020
@nielsvanvelzen
Copy link
Member

I think we should actually look into what additional changes we should make to fix #153 instead of removing the appmode, as it does make some changes that are required in the webui.

@Maxr1998
Copy link
Member Author

I think we should actually look into what additional changes we should make to fix #153 instead of removing the appmode, as it does make some changes that are required in the webui.

We could first try whether appMode='cordova' works better, yes. But if it's an obscure bug that can't easily be fixed, I wouldn't spend too much time on it..
The cast code has issues regardless of the appMode.

@nielsvanvelzen
Copy link
Member

Setting the appmode to cordova is the same as android

nielsvanvelzen
nielsvanvelzen approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just revert it for now

@nielsvanvelzen nielsvanvelzen merged commit 5eb0eae into master Sep 30, 2020
@nielsvanvelzen nielsvanvelzen deleted the revert-146-appmode branch September 30, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting appMode to 'android' prevents server connection on fresh installs (rc.7)
2 participants
@Maxr1998 @nielsvanvelzen