Change Icon type to String and add Application type field to in AppSchema #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 86.75% 86.76% +0.01%
==========================================
Files 89 89
Lines 6024 6024
==========================================
+ Hits 5226 5227 +1
+ Misses 798 797 -1
☔ View full report in Codecov by Sentry. |
medchedli
changed the title
medchedli
changed the title
nour-borgi
reviewed
Oct 25, 2023
| @@ -30,4 +32,4 @@ const AppSchema = new Schema({ | |||
| }) | |||
|
|
|||
| export const AppModelAPI = connectionAPI.model('App', AppSchema) | |||
| export const AppModel = connectionDefault.model('App', AppSchema) | |||
| export const AppModel = connectionDefault.model('App', AppSchema) | |||
There was a problem hiding this comment.
Please add empty line at the end. Actually you need to run this: npm run lint:fix
It will prettier and lint the code
|
Duplicate of #1212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the application Icon type from Buffer to String and added application type (which can holds either "link" or "embedded" as values)