Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix #1212

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Hotfix #1212

merged 4 commits into from
Nov 2, 2023

Conversation

bradsawadye
Copy link
Contributor

Add missing type property and change app's icon type into string

@bradsawadye
Add type property and convert icon into string type
5c325dd 
The data type that was being used was causing the icon to become corrupted. It was being formated into an invalid icon
@bradsawadye
Correct the app type, should be link or embedded
276516d
@bradsawadye
Bump the proj version
118ca21
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69e71eb) 86.76% compared to head (1f8a582) 86.76%.

❗ Current head 1f8a582 differs from pull request most recent head 130d8bc. Consider uploading reports for the commit 130d8bc to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          89       89           
  Lines        6024     6024           
=======================================
  Hits         5227     5227           
  Misses        797      797
Files Coverage Δ
src/model/apps.js 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@medchedli medchedli mentioned this pull request Nov 1, 2023
Closed
@bradsawadye bradsawadye merged commit 3b9a686 into master Nov 2, 2023
4 checks passed
@bradsawadye bradsawadye deleted the hotfix branch November 2, 2023 06:22
@medchedli medchedli mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medchedli medchedli medchedli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradsawadye @medchedli