-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED JENKINS-9104] Veto killing mspdbsrv.exe #19
Conversation
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
I would propose not to merge this PR till the new LTS gets released |
This PR promises to fix an issue which popped up during the current LTS cycle and which gives huge problems to a lot of people. (See bug 9104 linked above). It would be very helpful to be able to resolve this fast. |
A new Jenkins LTS is out, can we merge this now? |
+1 for the merge. 1.609.x will be the most popular one for several month, but an upgrade to 1.625 would be a general recommendation in any case. |
@oleg-nenashev: would you change the dependeny during the merge or should I update the PR? Should we depend on 1.625.1? |
Any update on this? |
Seems @gboissinot is busy with other things. |
Making use of the newly introduced ProcessKillingVeto extension point, we now make sure that mspdbsrv.exe survives process killing during build cleanup. This requires a Jenkins version >= 1.625, the new extension point was added there. I marked the extension as optional, so that the msbuild plugin should still work with older Jenkins releases.
I updated the PR to make msbuild depend on 1.625 and made the new classes use spaces all over ;) Could someone please merge it? I'd like to close this topic. |
[FIXED JENKINS-9104] Veto killing mspdbsrv.exe
* | ||
* @author Daniel Weber <daniel.weber.dev@gmail.com> | ||
*/ | ||
@Extension(optional = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this to be marked optional, or the Javadoc comment above, as the minimum Jenkins version for this plugin now is 1.625.
This reintroduces pull request jenkinsci#19 again.
Making use of the newly introduced ProcessKillingVeto extension point,
we now make sure that mspdbsrv.exe survives process killing during build
cleanup.
This requires a Jenkins version >= 1.619, the new extension point was
added there. I marked the extension as optional, so that the msbuild
plugin should still work with older Jenkins releases.