Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-9104] Veto killing mspdbsrv.exe #19

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

DanielWeber
Copy link
Contributor

Making use of the newly introduced ProcessKillingVeto extension point,
we now make sure that mspdbsrv.exe survives process killing during build
cleanup.

This requires a Jenkins version >= 1.619, the new extension point was
added there. I marked the extension as optional, so that the msbuild
plugin should still work with older Jenkins releases.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

  • You bump the dependency to 1.619
    • This version is not LTS
    • There is no LTS above this version
  • The PR uses tabs as a line separator, but other classes use spaces

I would propose not to merge this PR till the new LTS gets released

@Frank-Schmitt
Copy link

This PR promises to fix an issue which popped up during the current LTS cycle and which gives huge problems to a lot of people. (See bug 9104 linked above). It would be very helpful to be able to resolve this fast.

@Frank-Schmitt
Copy link

A new Jenkins LTS is out, can we merge this now?

@oleg-nenashev
Copy link
Member

+1 for the merge. 1.609.x will be the most popular one for several month, but an upgrade to 1.625 would be a general recommendation in any case.

@DanielWeber
Copy link
Contributor Author

@oleg-nenashev: would you change the dependeny during the merge or should I update the PR? Should we depend on 1.625.1?

@dgrunwald
Copy link

Any update on this?

@oleg-nenashev
Copy link
Member

Seems @gboissinot is busy with other things.
@DanielWeber yes, 1.625 should be fine. 1.642.1 is coming soon

Making use of the newly introduced ProcessKillingVeto extension point,
we now make sure that mspdbsrv.exe survives process killing during build
cleanup.

This requires a Jenkins version >= 1.625, the new extension point was
added there. I marked the extension as optional, so that the msbuild
plugin should still work with older Jenkins releases.
@DanielWeber
Copy link
Contributor Author

I updated the PR to make msbuild depend on 1.625 and made the new classes use spaces all over ;)

Could someone please merge it? I'd like to close this topic.

gboissinot added a commit that referenced this pull request Jan 15, 2016
[FIXED JENKINS-9104] Veto killing mspdbsrv.exe
@gboissinot gboissinot merged commit 48084be into jenkinsci:master Jan 15, 2016
*
* @author Daniel Weber <daniel.weber.dev@gmail.com>
*/
@Extension(optional = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this to be marked optional, or the Javadoc comment above, as the minimum Jenkins version for this plugin now is 1.625.

estyrke pushed a commit to estyrke/msbuild-plugin that referenced this pull request Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants