Revert "[FIXED JENKINS-9104] Veto killing mspdbsrv.exe" #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gboissinot Any particular reason for the revert? CC @DanielWeber |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
gboissinot
added a commit
that referenced
this pull request
Jan 17, 2016
Revert "[FIXED JENKINS-9104] Veto killing mspdbsrv.exe"
|
@gboissinot was something wrong with my commit? |
|
No problem, Pull request merged. |
|
@gboissinot But you just merged this PR, which reverts mine (PR 19), and then created a new release of the msbuild plugin (without my change). If there is a problem with my PR 19, please let me know so that I can fix it. |
|
@DanielWeber Sorry for this wrong manipulation. Please make a new pull request. |
estyrke
pushed a commit
to estyrke/msbuild-plugin
that referenced
this pull request
Jan 20, 2016
This reintroduces pull request jenkinsci#19 again.
|
I made a try at reviving @DanielWeber 's code. Let me know if I'm out of line here, but I thought I'd spare you others the work. |
|
@estyrke Not out of line, thanks :) |
gboissinot
added a commit
that referenced
this pull request
Feb 7, 2016
Revert "Merge pull request #20 from jenkinsci/revert-19-master"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19