simplify UI and exposed Data model #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Nov 8, 2018
| * @param passphrase the password. | ||
| * @param description the description. | ||
| */ | ||
| @DataBoundConstructor | ||
| public BasicSSHUserPrivateKey(CredentialsScope scope, String id, String username, String privateKey, | ||
| String passphrase, |
There was a problem hiding this comment.
Should be of type Secret, and should be moved into a @DataBoundSetter.
There was a problem hiding this comment.
agree, didn't want to make more changes that strictly required, but I'm fine to get one step further
There was a problem hiding this comment.
why use a DataBoundSetter ? Does it make any sense to create a SSHUserPrivateKey without a private key ?
| String description) { | ||
| super(scope, id, username, description); | ||
| privateKey = StringUtils.trimToNull(privateKey); | ||
| this.privateKeySource = privateKey == null ? null : new DirectEntryPrivateKeySource(privateKey); |
There was a problem hiding this comment.
What would a null private key mean?
| } | ||
|
|
||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
Should also deprecate PrivateKeySourceDescriptor.
| @@ -26,6 +26,7 @@ | |||
| import com.cloudbees.jenkins.plugins.sshcredentials.SSHUserPrivateKey; | |||
| import com.cloudbees.plugins.credentials.CredentialsProvider; | |||
| import com.cloudbees.plugins.credentials.CredentialsScope; | |||
| import com.google.common.base.Optional; | |||
jvz
approved these changes
Nov 8, 2018
|
BTW merge with |
As only directly entered key is supported for SECURITY-440 Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
|
Thanks, you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of SECURITY-440 only directly entered private key is supported, others legacy flavours are automatically migrated. This PR do simplify the UI to only expose this directly entered key as a single textarea field.
It also make exposed data model cleaner, typically configuration-as-code would avoid a deep nested model to define private key