Update dependencies and clean up #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
Signed-off-by: Matt Sicker <[email protected]>
jglick
approved these changes
Mar 1, 2019
| </j:forEach> | ||
| </table> | ||
| </j:scope> | ||
| <f:hetero-radio field="privateKeySource" descriptors="${descriptor.privateKeySources}"/> |
There was a problem hiding this comment.
Or we could just simplify the UI by hard-coding the single direct-entry source. I struggle to imagine what other kind could be added which would not suffer from the security problems of the two deleted ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the plugin pom to the latest, removes some unused files, and cleans up the views still remaining.
@reviewbybees @jglick @daniel-beck @oleg-nenashev