KeyStoreScanner is not able to monitor a symlink file and always resolves to the target. #8786
Assignees
Labels
Bug
For general bugs on Jetty side
Comments
lachlan-roberts
added a commit
that referenced
this issue
Oct 31, 2022
…iases Signed-off-by: Lachlan Roberts <[email protected]>
|
I miss why do we want to monitor the symlink, seems to make no sense to me? |
|
The symlink can be changed to point to a different location? |
|
@lachlan-roberts don't forget to set labels and projects. |
|
A user was requesting this feature, they wanted to modify the symlink file to point to a new target instead of just changing the target file of the symlink. We had a test for it which was wrong. So very least we should fix the test to verify the behaviour we expect. |
joakime
moved this from To do
to 🔖 Review in progress
in Jetty 10.0.13 / 11.0.13 - FROZEN
joakime
moved this from 🔖 Review in progress
to To do
in Jetty 10.0.13 / 11.0.13 - FROZEN
Repository owner
moved this from To do
to ✅ Done
in Jetty 10.0.13 / 11.0.13 - FROZEN
Nov 10, 2022
lachlan-roberts
added a commit
that referenced
this issue
Nov 10, 2022
…er-Symlink Issue #8786 - add configuration for KeyStoreScanner to not resolve aliases
joakime
added a commit
that referenced
this issue
Dec 6, 2022
…nges + Removed changes from #8786 and #8787 + More test cases Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
added a commit
that referenced
this issue
Dec 7, 2022
…nges (#9014) * Issue #8973 - Rework KeyStoreScanner handling for symlink related changes + Removed changes from #8786 and #8787 + More test cases + revert jetty.sslContext.reload.followLinks boolean + Scanner should follow its own linkOptions setting + remove bad documentation in module-ssl-reload.adoc Signed-off-by: Joakim Erdfelt <[email protected]> Signed-off-by: Lachlan Roberts <[email protected]> Co-authored-by: Lachlan Roberts <[email protected]>
|
This feature has been further updated as part of PR #9014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
9.4.x, 10.0.x, 11.0.x
Description
KeyStoreScanneris not able to monitor a symlink file and always resolves to the target.There is a test
org.eclipse.jetty.test.KeyStoreScannerTest#testReloadChangingSymbolicLinkwhich is incorrectly testing that this use case works, but it is currently not possible to configure inKeyStoreScanner.The text was updated successfully, but these errors were encountered: