Issue #8786 - add configuration for KeyStoreScanner to not resolve aliases #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iases Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
Nov 1, 2022
There was a problem hiding this comment.
@lachlan-roberts why is this necessary? See also comment on the issue.
sbordet
requested changes
Nov 2, 2022
There was a problem hiding this comment.
"KeyStore" has the capital "S", so in the test class this should respected in variable names and pretty much everywhere.
Also, I won't mind to have the jetty-ssl-context-reload.xml modified to support this additional property, and Jetty module ssl-reload as well.
Also, please update the documentation module-ssl-reload.adoc with a small paragraph after the module properties that explains with an example the difference between the 2 cases.
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/KeyStoreScanner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
Nov 3, 2022
...tation/jetty-documentation/src/main/asciidoc/operations-guide/modules/module-ssl-reload.adoc
Outdated
Show resolved
Hide resolved
tests/test-integration/src/test/java/org/eclipse/jetty/test/KeyStoreScannerTest.java
Show resolved
Hide resolved
tests/test-integration/src/test/java/org/eclipse/jetty/test/KeyStoreScannerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
Nov 3, 2022
joakime
added a commit
that referenced
this pull request
Dec 6, 2022
…nges + Removed changes from #8786 and #8787 + More test cases Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
added a commit
that referenced
this pull request
Dec 7, 2022
…nges (#9014) * Issue #8973 - Rework KeyStoreScanner handling for symlink related changes + Removed changes from #8786 and #8787 + More test cases + revert jetty.sslContext.reload.followLinks boolean + Scanner should follow its own linkOptions setting + remove bad documentation in module-ssl-reload.adoc Signed-off-by: Joakim Erdfelt <[email protected]> Signed-off-by: Lachlan Roberts <[email protected]> Co-authored-by: Lachlan Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8786
Allow the
KeyStoreScannerto monitor the symlink file itself instead of the target of the symlink.