file bACS_213.v modified #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use combinational logic to calculate suma and sumb, and sequential logic to calculate acs_ppm_out and acs_Bx_out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello sir, I tried running the original code with VCS and Verdi, and found my wave is different from the one in path 'Vit_b213/src/verilog.fsdb', also the Dx output is incorrect. After reviewing all the code and docs, I believe there might be a solution by modifying the file 'bACS_213': using combinational logic to calculate suma and sumb, and sequential logic to calculate acs_ppm_out and acs_Bx_out. When I did this change, the wave is consistent with the code in path 'Vit_b213/src/verilog.fsdb', I would appreciate your feedback, thx~