Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for kaniko docker images #477

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

cwholmes
Copy link
Contributor

@cwholmes cwholmes commented Apr 8, 2021

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

My team uses kaniko a lot for building docker images inside a kubernetes cluster (using the kubernetes-plugin). This currently requires adding dind as a container and pushing through the dind container after creating a tar with kaniko. We would like to avoid this by pushing with kaniko and creating the build info for the docker image.

This logic is somewhat replicating the jfrog rt build-docker-create command seen here:

https://github.com/jfrog/project-examples/tree/master/kaniko-example#kaniko-example

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@cwholmes
Copy link
Contributor Author

cwholmes commented Apr 8, 2021

I have read the CLA Document and I hereby sign the CLA

@cwholmes cwholmes force-pushed the kaniko-build-info-support branch from 53eb00a to 497d43a Compare April 8, 2021 21:34
@cwholmes cwholmes force-pushed the kaniko-build-info-support branch from 497d43a to 87bfc85 Compare April 8, 2021 21:36
@cwholmes
Copy link
Contributor Author

@eyalbe4 Could you please take a look at this change? My organization would really like to be able to support artifactory builds with kaniko. Thanks.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 15, 2021

Definitely @cwholmes!
Thanks so much for this contributions.
Give us just a few more days.

@yahavi
Copy link
Member

yahavi commented May 25, 2021

@cwholmes,
Thanks for this contribution!
We recently changed the Artifactory clients to services-style attitude. Basically, it replaces ArtifactoryBuildInfoClient and ArtifactoryDependenciesClient by ArtifactoryManager and removes the HTTP client requests and responses handling.

Therefore before merging your PR, we should merge from the master branch and migrate to the Artifactory manager.
Would you like to pull the latest changes from the master branch?

You can use this as a reference to help you merging the BuildDockerCreate class: cwholmes@1cd2fe6

Please let us know if you encounter any difficulties.

@yahavi yahavi self-requested a review May 25, 2021 07:30
@cwholmes
Copy link
Contributor Author

@yahavi I have made the requested changes and used the artifactory manager.

@yahavi yahavi merged commit 29854ff into jfrog:master Jun 7, 2021
@yahavi yahavi mentioned this pull request Jun 7, 2021
1 task
@yahavi
Copy link
Member

yahavi commented Jun 7, 2021

@cwholmes,
Thanks again for your contribution. We merged this PR to give you the credit and respect you're truly deserved.

I'd like to let you know that we elevated your PR to support both Kaniko and JIB.
We are working on follow-up PRs to add this support in the Jenkins Artifactory plugin:

We'd appreciate any feedback/review/thoughts before we merge the above PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants