-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for kaniko docker images #477
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
53eb00a
to
497d43a
Compare
497d43a
to
87bfc85
Compare
@eyalbe4 Could you please take a look at this change? My organization would really like to be able to support artifactory builds with kaniko. Thanks. |
Definitely @cwholmes! |
@cwholmes, Therefore before merging your PR, we should merge from the master branch and migrate to the Artifactory manager. You can use this as a reference to help you merging the BuildDockerCreate class: cwholmes@1cd2fe6 Please let us know if you encounter any difficulties. |
@yahavi I have made the requested changes and used the artifactory manager. |
@cwholmes, I'd like to let you know that we elevated your PR to support both Kaniko and JIB.
We'd appreciate any feedback/review/thoughts before we merge the above PRs. |
My team uses kaniko a lot for building docker images inside a kubernetes cluster (using the kubernetes-plugin). This currently requires adding dind as a container and pushing through the dind container after creating a tar with kaniko. We would like to avoid this by pushing with kaniko and creating the build info for the docker image.
This logic is somewhat replicating the
jfrog rt build-docker-create
command seen here:https://github.com/jfrog/project-examples/tree/master/kaniko-example#kaniko-example