Add support for Kaniko and JIB #512
Conversation
| if (imageDigest == null || imageDigest.isNull()) { | ||
| throw new RuntimeException("Missing \"imageDigest\" in file: \"" + jibImageFiles + "\""); | ||
| } | ||
| imageFilesWithDigests.add(new ImageFileWithDigest(imageName.asText(), imageDigest.asText())); |
There was a problem hiding this comment.
Should this be adding a image file instance for each of the tags in the file?
There was a problem hiding this comment.
Unlike Kaniko, the image file of JIB contains only one image. It is concluded from the description of the jib-image.json:
The path of the image metadata json file written out during the build. Relative paths are resolved relative to the project root.
To support multiple JIB image files, we allow providing a Wildcard pattern. For example, the default pattern is: */target/jib-image.json.
...actor-docker/src/main/java/org/jfrog/build/extractor/docker/extractor/BuildDockerCreate.java
Outdated
Show resolved
Hide resolved
...actor-docker/src/main/java/org/jfrog/build/extractor/docker/extractor/BuildDockerCreate.java
Outdated
Show resolved
Hide resolved
| ArrayListMultimap.create(clientConfiguration.publisher.getMatrixParams().asMultimap()), | ||
| clientConfiguration.publisher.getRepoKey(), | ||
| clientConfiguration.getLog()); | ||
|
|
||
| // Exe docker push & collect build info. | ||
| // Exe build-docker-create & collect build info. | ||
| dockerBuildCreate.executeAndSaveBuildInfo(clientConfiguration); |
There was a problem hiding this comment.
executeAndSaveBuildInfo --> createAndPublish
There was a problem hiding this comment.
The executeAndSaveBuildInfo is a method of PackageManagerExtractor, the parent class.
Follow up #477: