Update to RustDDS with DeserializeSeed support
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
Required because of new bound on `take_one_seed`.
phil-opp
force-pushed
the
deserialize-seed-2
branch
from
23cbcc8 to
008b76c
Compare
|
Updated to use Atostek/RustDDS#334. I didn't squash the commits yet to make it clear what changed. |
Can we have similar functionality (stateful deserialization) for If so, do you have any pointers to how I can make that work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
ros2-clientto the RustDDS changes in Atostek/RustDDS#313.The main changes are:
ServiceDeserializerAdapterno_key::DeserializerAdaptertrait changed.WrapperDecoderand implementDefaultDecoderDeserializeOwnedbounds that are no longer needed.take_seedandasync_stream_seedmethods onSubscriptionthat support stateful deserialization using serde'sDeserializeSeedtrait.This PR is marked as a draft as it should only be merged once Atostek/RustDDS#313 is merged and released.