Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ros2-client to latest version #457

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Update ros2-client to latest version #457

merged 4 commits into from
Apr 16, 2024

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Apr 5, 2024 •
edited
Loading

  • Update to latest upstream releases of ros2-client and rustdds
    • Our DeserializeSeed PR was merged and is now part of the official releases 🚀
    • Also includes some service-related fixes.
  • Adjust generated code and examples for latest ros2-client version

@phil-opp
Copy link
Collaborator Author

Build fails on Windows because of Atostek/ros2-client#27.

@phil-opp phil-opp marked this pull request as ready for review April 16, 2024 14:08
@phil-opp
Copy link
Collaborator Author

Our DeserializeSeed PR was merged and released in v0.7.1, so we don't need our fork anymore 🎉. I updated this PR to use the official crates.io releases. The new release should also fix Atostek/ros2-client#27.

@phil-opp phil-opp requested a review from haixuanTao April 16, 2024 14:41
@phil-opp phil-opp merged commit 1c2dc46 into main Apr 16, 2024
17 checks passed
@phil-opp phil-opp deleted the update-ros2-client branch April 16, 2024 15:25
@haixuanTao haixuanTao mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @haixuanTao