chore: remove clip_hg #786
Conversation
github-actions
bot
added
size/m
area/cicd
area/housekeeping
area/testing
component/server
labels
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
===========================================
- Coverage 85.92% 70.14% -15.79%
===========================================
Files 21 20 -1
Lines 1137 1055 -82
===========================================
- Hits 977 740 -237
- Misses 160 315 +155
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -42,7 +42,6 @@ jobs: | |||
| python -m pip install wheel | |||
| pip install --no-cache-dir "client/[test]" | |||
| pip install --no-cache-dir "server/[onnx]" | |||
| pip install --no-cache-dir "server/[huggingface]" | |||
| @@ -58,7 +59,6 @@ | |||
| ] | |||
| + (['onnxruntime-gpu>=1.8.0'] if sys.platform != 'darwin' else []), | |||
| 'tensorrt': ['nvidia-tensorrt'], | |||
| 'huggingface': ['transformers>=4.16.2'], | |||
There was a problem hiding this comment.
change the dependency key to "mclip"
There was a problem hiding this comment.
why put mclip in extra requirements, since it is now part of basic models to support
There was a problem hiding this comment.
I changed my mind, let's use transformers as the key. mclip actually depends on transformers.
| @@ -58,7 +59,6 @@ | |||
| ] | |||
| + (['onnxruntime-gpu>=1.8.0'] if sys.platform != 'darwin' else []), | |||
| 'tensorrt': ['nvidia-tensorrt'], | |||
| 'huggingface': ['transformers>=4.16.2'], | |||
There was a problem hiding this comment.
I changed my mind, let's use transformers as the key. mclip actually depends on transformers.
Co-authored-by: felix-wang <[email protected]>
Co-authored-by: felix-wang <[email protected]>
Co-authored-by: felix-wang <[email protected]>
This PR removes the CLIP hugging face executor since hg does not have new models and every other model can be used from open-clip