-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove clip_hg #786
Changes from 4 commits
b62470c
a2ccb89
a0a1af2
e8b6044
3821b30
f0478fd
28cae46
e21bf70
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ | |
] | ||
+ (['onnxruntime-gpu>=1.8.0'] if sys.platform != 'darwin' else []), | ||
'tensorrt': ['nvidia-tensorrt'], | ||
'huggingface': ['transformers>=4.16.2'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. change the dependency key to "mclip" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why put mclip in extra requirements, since it is now part of basic models to support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed my mind, let's use |
||
'mclip': ['transformers>=4.16.2'], | ||
ZiniuYu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
classifiers=[ | ||
'Development Status :: 5 - Production/Stable', | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mclip
would also need this dep