fix: torchvision version to avoid compatibility issue #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 80.28% 78.26% -2.03%
==========================================
Files 22 22
Lines 1633 1633
==========================================
- Hits 1311 1278 -33
- Misses 322 355 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZiniuYu
reviewed
Nov 25, 2022
server/setup.py
Outdated
| @@ -45,7 +45,7 @@ | |||
| 'ftfy', | |||
| 'torch', | |||
| 'regex', | |||
| 'torchvision', | |||
| 'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision', | |||
There was a problem hiding this comment.
what about
Suggested change
| 'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision', | |
| 'torchvision==0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision', |
There was a problem hiding this comment.
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
numb3r3
requested changes
Nov 25, 2022
server/setup.py
Outdated
| @@ -45,7 +45,7 @@ | |||
| 'ftfy', | |||
| 'torch', | |||
| 'regex', | |||
| 'torchvision', | |||
| 'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision', | |||
There was a problem hiding this comment.
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
numb3r3
requested changes
Nov 25, 2022
ZiniuYu
reviewed
Nov 25, 2022
| @@ -45,7 +45,7 @@ | |||
| 'ftfy', | |||
| 'torch', | |||
| 'regex', | |||
| 'torchvision', | |||
| 'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision', | |||
There was a problem hiding this comment.
Suggested change
| 'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision', | |
| 'torchvision<=0.13.0' if sys.version_info[:2] <= (3, 7) else 'torchvision', |
There was a problem hiding this comment.
what's the difference between these two?
There was a problem hiding this comment.
numb3r3
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves the issue. We fix the
torchvisionversion to avoid this.