Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: torchvision version to avoid compatibility issue #866

Merged
merged 4 commits into from
Nov 25, 2022
Merged

fix: torchvision version to avoid compatibility issue #866

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7eb41e4
fix: fix torchvision version to avoid compatibility issue
jemmyshin Nov 25, 2022
73b7b26
fix: fix torchvision version to avoid compatibility issue
jemmyshin Nov 25, 2022
24b32c1
fix: fix python version for torchvision
jemmyshin Nov 25, 2022
fbc72de
fix: fix python version for torchvision
jemmyshin Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
'ftfy',
'torch',
'regex',
'torchvision',
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
numb3r3 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
'torchvision<=0.13.0' if sys.version_info[:2] <= (3, 7) else 'torchvision',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between these two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.7.x: x ∈ [0, 15]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.python.org/downloads/

'jina>=3.8.0',
'prometheus-client',
'open_clip_torch>=1.3.0',
Expand Down