Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using named cookies to get a correct redirect #1492

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Using named cookies to get a correct redirect #1492

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b1ad88
Using named cookies
Dec 5, 2022
901b699
Prevent from deleting wlan.ini file
Dec 5, 2022
1473a59
Missed "
Dec 5, 2022
e6227d3
Revert "Prevent from deleting wlan.ini file"
Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions code/components/jomjol_fileserver_ota/server_file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,12 +829,6 @@ static esp_err_t delete_post_handler(httpd_req_t *req)
return ESP_FAIL;
}

if (filename == 'wlan.ini') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Slider0007 What is the reason you reverted this change?
Will you add it again in a separate pull request?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caco3: I wasn't involved in this. I assume you mean @parhedberg.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, sorry!

=> @parhedberg What is the reason you reverted this change?
Will you add it again in a separate pull request?
For me it looks ok!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry.. It is me that is struggeling with my branches.. I made a new pull request with only the wlan fix in it...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem!

Thanks for your contribution in #1509 !

ESP_LOGE(TAG, "Trying to delete protected file : %s", filename);
httpd_resp_send_err(req, HTTPD_500_INTERNAL_SERVER_ERROR, "Not allowed to delete wlan.ini");
return ESP_FAIL;
}

if (stat(filepath, &file_stat) == -1) {
ESP_LOGE(TAG, "File does not exist : %s", filename);
/* Respond with 400 Bad Request */
Expand Down