Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Display relative date instead of date stamp in user action log module #32910

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[4] Display relative date instead of date stamp in user action log module #32910

merged 1 commit into from
Mar 31, 2021

Conversation

PhilETaylor
Copy link
Contributor

Summary of Changes

Propose to use a relative date (5 minutes ago) in the Latest Actions module rather than a date stamp. (2020-02-01)

Testing Instructions

Ensure you have some Actions in your User Action Log
Check the Home Dashboard -> Latest Actions module - look at it
Apply PR
Look at it again and note the times are now relative

Actual result BEFORE applying this Pull Request

Screenshot 2021-03-28 at 21 04 36

Expected result AFTER applying this Pull Request

Screenshot 2021-03-28 at 21 04 18

Documentation Changes Required

none

@PhilETaylor PhilETaylor changed the title Display relative date instead of date stamp [4] Display relative date instead of date stamp Mar 28, 2021
@PhilETaylor PhilETaylor changed the title [4] Display relative date instead of date stamp [4] Display relative date instead of date stamp in user action log module Mar 28, 2021
@rjharishabh
Copy link
Contributor

It looks good

@rjharishabh
Copy link
Contributor

I have tested this item ✅ successfully on 23cbf31

@Harmageddon
Copy link
Contributor

#32911 (comment) also applies here.

@ceford
Copy link
Contributor

ceford commented Mar 29, 2021

I have tested this item ✅ successfully on 23cbf31

It seems to me seeing One hour ago has more immediate impact than the date. It also prompted me look at the User Actions Log. If it is not to be configurable I prefer the period ago to the date.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32910.

@toivo
Copy link
Contributor

toivo commented Mar 29, 2021

I have tested this item ✅ successfully on 23cbf31

Tested successfully in Beta8-dev of 29 March in Wampserver 3.2.4 using PHP 8.0.2.

BTW, the User Actions Log under Users shows both the relative date and the time stamp.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32910.

@meinhoonharsh
Copy link

I have tested this item ✅ successfully on 23cbf31

Now It Looks a way Better

Before:

image

After:

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32910.

@Quy
Copy link
Contributor

Quy commented Mar 30, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32910.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 30, 2021
@rdeutz rdeutz merged commit db414e7 into joomla:4.0-dev Mar 31, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2021
@zero-24 zero-24 added this to the Joomla 4.0 milestone Mar 31, 2021
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants