-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Show relative date instead of date time in logged in module #32911
Conversation
It always shows Less than a minute ago. |
This comment was marked as abuse.
This comment was marked as abuse.
Without this PR, logged in date and time shown, I think results after this PR should be the same as #32910 |
This comment was marked as abuse.
This comment was marked as abuse.
Thanks for clarification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested: Use Factory::getDate(..)
This comment was marked as abuse.
This comment was marked as abuse.
Can we please make this configurable? As I created PR #31675 already some time ago, where it is documented that not everyone prefers the relative display instead of an absolute one. If we add relative display not only for the action logs, but also in other places in core, it might be better to have a user-specific setting for this instead of the parameter I added for com_actionlogs. |
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 43cd9ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32911. |
i'm not sure if this is the way to go ... like #32910 |
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: Phil E. Taylor <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
maybe i've been unexplicative |
This comment was marked as abuse.
This comment was marked as abuse.
grr |
This comment was marked as abuse.
This comment was marked as abuse.
That's correct. Still I'm confused by things like "2 weeks ago" or "5 days ago" - was it Wednesday? Thursday? Let me calculate... Though I see your point here:
Whether one or the other is better is a question of personal taste, thus, I'd prefer the parameter. As you see in #31675, there are several people saying "just get rid of the parameter and display it in absolute format" and several saying "just get rid of the parameter and display it in relative format". I agree that the argumentation for relative dates is stronger in this case here than for the whole action logs table.
So I'd kindly ask you to at least include this tooltip in your PRs to give users the chance to see the absolute date.
Seems a bit counterintuitive to me that changing the display would be considered a bug fix or cosmetical change (for 4.0), but making it configurable would be a new feature (4.1)? Okay, you two are writing faster than I am.
Would be very much appreciated! :-) |
Signed-off-by: Phil E. Taylor <[email protected]>
I have tested this item ✅ successfully on 2479611 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32911. |
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 2479611 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32911. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32911. |
Did anyone tested that filtering by date is still functional after applying this PR? |
This comment was marked as abuse.
This comment was marked as abuse.
Yeah, just realised that this is not a list view although it resembles one |
I'm against this change for multiple reasons but most of them are personal ;-) Anyway column header is "Date" the value "2 minutes ago" is not a date so it should be "last seen" aside this I prefer real dates especially if the values are bigger then a day. Also there is no fallback like a tooltip with the real date. |
Summary of Changes
Propose showing of relative date instead of date time in the Logged in Users module in admin.
Testing Instructions
Check the Home Dashboard -> Logged In Users module - look at it
Apply PR
Look at it again and note the times are now relative
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none