Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Target-specific features not supported by Cargo #1358

Closed
ankane opened this issue Jan 14, 2023 · 2 comments
Closed

Target-specific features not supported by Cargo #1358

ankane opened this issue Jan 14, 2023 · 2 comments
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@ankane
Copy link

ankane commented Jan 14, 2023

Hi, hope your year is off to a good start.

Cargo doesn't currently support target-specific features (rust-lang/cargo#1197), so the pattern used in #1297 ends up enabling both the compile-time-rng and runtime-rng features of ahash on all platforms.

arrow2/Cargo.toml

Lines 100 to 106 in 211be21

# faster hashing
[target.'cfg(target_arch = "wasm32")'.dependencies]
ahash = { version = "0.8", features=["compile-time-rng"] }
getrandom = { version = "0.2", features = ["js"] }
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
ahash = { version = "0.8", features=["runtime-rng"] }

This pulls in the dependencies for both on all platforms.

@hzuo
Copy link
Contributor

hzuo commented Feb 14, 2023

Should be fixed by #1407

@ankane
Copy link
Author

ankane commented Mar 23, 2023

Thanks @hzuo!

@ankane ankane closed this as completed Mar 23, 2023
@jorgecarleitao jorgecarleitao added bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog labels Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

No branches or pull requests

3 participants