This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM special-casing for
ahash
introduced by #1297 is problematic for a couple of reasons:compile-time-rng
feature is useless without first disablingruntime-rng
(which is enabled as a default feature). When both are enabled,runtime-rng
takes precendence but we end up bringing in extraneous dependencies forcompile-time-rng
. It's also misleading to see "compile-time-rng" when in reality it's still runtime-rng.compile-time-rng
(which we could by settingdefault-features = false
), there's no reason to includegetrandom
at all since there's no need to get randomness at runtime. But IMO it's a bad default since it leads to non-deterministic / uncacheable builds - see Disable use of const_random! by default rust-lang/hashbrown#155.target_arch
also made this config apply towasm32-unknown-emscripten
builds too, even though no special-casing is required for Emscripten. See getrandom's docs on WASM support.