Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Upgraded ahash to v0.8 #1297

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Nov 13, 2022

This is a resubmission of #1271, which was reverted in 6e46651, due to compilation errors with the wasm32 target. It builds on #1274 to fix those compilation errors.

Closes #1274.

@benesch benesch mentioned this pull request Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 83.11% // Head: 83.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (16ff95d) compared to base (95e117d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   83.11%   83.12%           
=======================================
  Files         369      369           
  Lines       40168    40168           
=======================================
+ Hits        33386    33388    +2     
+ Misses       6782     6780    -2     
Impacted Files Coverage Δ
src/compute/hash.rs 100.00% <100.00%> (ø)
src/io/ipc/read/schema.rs 95.58% <0.00%> (-0.30%) ⬇️
src/io/ipc/read/stream_async.rs 76.71% <0.00%> (+2.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benesch
Copy link
Contributor Author

benesch commented Nov 13, 2022

@jorgecarleitao I believe this is ready to go. The clippy failures appear to be the result of new deprecations in v0.4.23 that are unrelated to this PR.

@jorgecarleitao
Copy link
Owner

Thanks! has a conflict, unfortunately.

This is a resubmission of jorgecarleitao#1271, which was reverted in 6e46651, due to
compilation errors with the wasm32 target. It builds on jorgecarleitao#1274 to fix
those compilation errors.

Closes jorgecarleitao#1274.

Co-authored-by: "Jorge C. Leitao" <[email protected]>
@benesch
Copy link
Contributor Author

benesch commented Nov 13, 2022

Thanks! has a conflict, unfortunately.

Boy, this PR is the gift that just won't stop giving. Fixed!

@jorgecarleitao jorgecarleitao changed the title Upgrade to ahash v0.8 Upgraded ahash to v0.8 Nov 15, 2022
@jorgecarleitao jorgecarleitao merged commit be81cae into jorgecarleitao:main Nov 15, 2022
@benesch benesch deleted the fix_hash branch November 15, 2022 04:41
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants