Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in computing slices of set bitmaps. #293

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

The slice iterator could go beyond bounds, which would trigger a panic e.g. in filter. This PR fixes this.

Closes #292

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #293 (3d90436) into main (0742edd) will increase coverage by 0.01%.
The diff coverage is 98.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   77.25%   77.26%   +0.01%     
==========================================
  Files         315      315              
  Lines       20791    20805      +14     
==========================================
+ Hits        16062    16075      +13     
- Misses       4729     4730       +1     
Impacted Files Coverage Δ
tests/it/bitmap/utils/slice_iterator.rs 98.90% <98.90%> (-1.10%) ⬇️
src/bitmap/immutable.rs 84.61% <100.00%> (+0.24%) ⬆️
src/bitmap/utils/slice_iterator.rs 94.02% <100.00%> (+1.49%) ⬆️
src/io/json/read/reader.rs 74.32% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0742edd...3d90436. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SliceIterator of last bytes is not correct
1 participant