Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added FixedSizeListScalar and FixedSizeBinaryScalar #786

Conversation

illumination-k
Copy link
Contributor

  • Adding FixedSizeListScalar and FixedSizeBinaryScalar
  • Supporting FixedSizeListScalar and FixedSizeBinaryScalar in new_scalar
  • Adding related test

related to #782 and #783

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #786 (45b6e78) into main (684c259) will increase coverage by 0.00%.
The diff coverage is 70.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files         317      319    +2     
  Lines       16623    16664   +41     
=======================================
+ Hits        11816    11846   +30     
- Misses       4807     4818   +11     
Impacted Files Coverage Δ
src/scalar/mod.rs 65.62% <0.00%> (-29.83%) ⬇️
src/scalar/fixed_size_binary.rs 84.61% <84.61%> (ø)
src/scalar/fixed_size_list.rs 100.00% <100.00%> (ø)
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684c259...45b6e78. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I left a small number of comments / suggestions. Awesome PR, @illumination-k !

src/scalar/fixed_size_binary.rs Show resolved Hide resolved
src/scalar/fixed_size_binary.rs Outdated Show resolved Hide resolved
Comment on lines 12 to 13
values: Arc<dyn Array>,
is_valid: bool,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about

Suggested change
values: Arc<dyn Array>,
is_valid: bool,
values: Option<Arc<dyn Array>>,

and remove is_valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I referred to ListScalar, but I think Option<Arc<dyn Array>> is better and value method should return Option<&Arc<dyn Array>> for consistency of other scalar.

StructScalar and ListScalar also have is_valid. Should we use Option and remove is_valid for them? (Maybe another PR)

@jorgecarleitao jorgecarleitao merged commit c80b39d into jorgecarleitao:main Jan 24, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jan 24, 2022
@jorgecarleitao jorgecarleitao changed the title Adding FixedSizeListScalar and FixedSizeBinaryScalar Added FixedSizeListScalar and FixedSizeBinaryScalar Jan 24, 2022
This was referenced Jan 24, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot, @illumination-k !

@illumination-k illumination-k deleted the feature/fixedsize-list-and-binary-scalar branch January 24, 2022 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants