This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
FixedSizeListScalar
andFixedSizeBinaryScalar
#786Added
FixedSizeListScalar
andFixedSizeBinaryScalar
#786Changes from 7 commits
40a0745
12b4eb8
d7c2a00
5e84054
b7c4beb
f6e4a7b
4b5a529
9583a5e
4bef2fb
8e971f6
63224cc
45b6e78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about
and remove
is_valid
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I referred to
ListScalar
, but I thinkOption<Arc<dyn Array>>
is better and value method should returnOption<&Arc<dyn Array>>
for consistency of other scalar.StructScalar
andListScalar
also haveis_valid
. Should we useOption
and removeis_valid
for them? (Maybe another PR)