Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hsi color for latest jsk_pcl_ros and enable to invoke several color filter #68

Merged
merged 1 commit into from
Nov 24, 2015

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Nov 24, 2015

Update hsi color for latest jsk_pcl_ros and enable to invoke several color filter
(I'll send PR to jsk_pcl_ros.)

@snozawa
Copy link
Contributor Author

snozawa commented Nov 24, 2015

Usage:
launch

roslaunch dxl_armed_turtlebot hsi_color_filter.launch DEFAULT_NAMESPACE:=/camera/depth_registered INPUT:=points h_min:=-20 h_max:=30 FILTER_NAME_SUFFIX:=red

and

roslaunch dxl_armed_turtlebot hsi_color_filter.launch DEFAULT_NAMESPACE:=/camera/depth_registered INPUT:=points h_min:=-127 h_max:=127 FILTER_NAME_SUFFIX:=all

Output

/camera/depth_registered/boxesred
/camera/depth_registered/hsi_outputred
...
/camera/depth_registered/boxesall
/camera/depth_registered/hsi_outputall
...

snozawa added a commit that referenced this pull request Nov 24, 2015
Update hsi color for latest jsk_pcl_ros and enable to invoke several color filter
@snozawa snozawa merged commit 99687fe into jsk-enshu:master Nov 24, 2015
@k-okada
Copy link
Member

k-okada commented Nov 24, 2015

新機能を入れたら必ずリリースしましょう.
リリースは

git clone https://github.com/jsk-enshu/robot-programming
cd robot-programming/
catkin_generate_changelog 
git diff
git commit -m "update CHANGELOG" -a
catkin_prepare_release 

です.

各人がちゃんとこちらの希望しているものを使っているかの確認は
「最新版を使っていますか」ではなく「rosversion dxl_armed_turtlebot」
としたら,2.1.4になっていますか,としましょう.

@snozawa
Copy link
Contributor Author

snozawa commented Nov 25, 2015

ありがとうございます。
去年はtagしてましたが、今年はその暇がなかったです(コマンド忘れたりしました)。
tagを2.1.5につけました。

ちなみにリリースの方法についての質問なのですが、
cloneが必要なのはcatkin_prepare_releaseが手元のmasterブランチを
githubのorigin/masterブランチにpushして、手元のmasterブランチを
更新する必要があるためでしょうか。

@k-okada
Copy link
Member

k-okada commented Nov 25, 2015

2015-11-25 11:00 GMT+09:00 Shunichi Nozawa [email protected]:

cloneが必要なのは

最新の状態でCHNAGELOGを作るようにするためです.
checkout master; git fetch --all; git pll origin/master / git reset --hard
origin/master
でもいいですが,間違いが無いように

git diff してなにも無ければタグはいらないです.2.1.4と2.1.5の間に変更はないですね.

c3a83ad

◉ Kei Okada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants