Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MOI v1 and JuMP v0.23 #190

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Update to MOI v1 and JuMP v0.23 #190

merged 5 commits into from
Mar 7, 2022

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 25, 2022

Closes #189
Closes #191
Closes #194

@joaquimg joaquimg mentioned this pull request Mar 2, 2022
@joaquimg
Copy link
Member

joaquimg commented Mar 2, 2022

@joaquimg
Copy link
Member

joaquimg commented Mar 6, 2022

All errors are this thing:

Without canonicalization: Test Failed at D:\a\DiffOpt.jl\DiffOpt.jl\test\utils.jl:21
  Expression: ($(Expr(:escape, :((∇zb * z' + z * ∇zb') / 2))), $(Expr(:escape, :dQb)), atol = $(Expr(:escape, :atol)), rtol = $(Expr(:escape, :rtol)))
   Evaluated: [0.0 0.0 0.0; 0.0 0.0 0.0; 0.0 0.0 0.0]  sparse([1, 2, 3, 1, 2, 3, 1, 2, 3], [1, 1, 1, 2, 2, 2, 3, 3, 3], [-1.5171209037542e-10, -8.484896114416807e-11, -2.1774988043867563e-5, -8.484896114416807e-11, 1.7065704367936932e-10, 1.3929080495566e-5, -2.1774988043867563e-5, 1.3929080495405566e-5, -0.00010831794236600524], 3, 3) (atol=0.0001, rtol=0.0001)
Stacktrace:
 [1] macro expansion
   @ C:\hostedtoolcache\windows\julia\1.7.2\x64\share\julia\stdlib\v1.7\Test\src\Test.jl:445 [inlined]
 [2] qp_test(solver::Type, lt::Bool, set_zero::Bool, canonicalize::Bool; dzb::Vector{Float64}, n::Int64, q::Vector{Float64}, dqf::Vector{Float64}, dqb::Vector{Float64}, Q::Matrix{Float64}, dQf::Matrix{Float64}, dQb::Nothing, fix_indices::Vector{Int64}, fix_values::Vector{Float64}, nfix::Int64, ub_indices::Vector{Int64}, ub_values::Vector{Float64}, nub::Int64, lb_indices::Vector{Int64}, lb_values::Vector{Float64}, nlb::Int64, h::Vector{Float64}, nle::Int64, dhf::Vector{Float64}, dhb::Vector{Float64}, G::Matrix{Float64}, dGf::Matrix{Float64}, dGb::Matrix{Float64}, b::Vector{Float64}, neq::Int64, dbf::Vector{Float64}, dbb::Nothing, A::Matrix{Float64}, dAf::Matrix{Float64}, dAb::Nothing, z::Nothing, dzf::Nothing, ∇zf::Nothing, ∇zb::Nothing, λ::Nothing, dλf::Vector{Float64}, dλb::Vector{Float64}, ∇λf::Nothing, ∇λb::Nothing, ν::Nothing, dνf::Nothing, dνb::Vector{Float64}, ∇νf::Nothing, ∇νb::Nothing, atol::Float64, rtol::Float64)
   @ Main D:\a\DiffOpt.jl\DiffOpt.jl\test\utils.jl:21
Test Summary:

setting atol = 0.0002 would solve this...

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #190 (833b023) into master (5e9590b) will decrease coverage by 7.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   88.17%   80.52%   -7.65%     
==========================================
  Files           8        8              
  Lines         837      837              
==========================================
- Hits          738      674      -64     
- Misses         99      163      +64     
Impacted Files Coverage Δ
src/moi_wrapper.jl 57.19% <0.00%> (-24.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9590b...833b023. Read the comment docs.

@joaquimg
Copy link
Member

joaquimg commented Mar 7, 2022

We lost 8% of coverage due to removing old MOI tests

@joaquimg joaquimg merged commit 041cffe into master Mar 7, 2022
@joaquimg
Copy link
Member

joaquimg commented Mar 7, 2022

I will deal with coverage in other PR

@blegat blegat deleted the bl/jump0.23 branch April 3, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants