MOI 1.0

[joaquimg]

No description provided.

[joaquimg]

@matbesancon waiting for approval to run :)

[odow]

[joaquimg]

Please :)

[matbesancon]

sorry about the delays! Am on the road for a bit

[odow]

You might say on the ROADef?

[matbesancon]

there are still minor things to adjust it seems, @joaquimg if you have the time

[matbesancon]

also @joaquimg you were invited as collaborator of the repo some time ago, if you accept you should be able to run CI directly 😛

[joaquimg]

Missed that! Just found in mailbox, but its expired. Can you re-send?
I will keep working on this!

[joaquimg]

Aaaand I am back asking for more CI, and a new collaborator invite XD.
All tests passing locally in win.

[odow]

I have CI power in the mean time

[codecov]

Codecov Report

Merging #60 (174a826) into master (a449c4b) will increase coverage by 0.91%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   84.41%   85.32%   +0.91%     
==========================================
  Files           6        6              
  Lines         539      593      +54     
==========================================
+ Hits          455      506      +51     
- Misses         84       87       +3     

Impacted Files	Coverage Δ
src/projections.jl	85.61% <96.15%> (+0.90%)	⬆️
src/chainrules.jl	100.00% <0.00%> (ø)
src/utils.jl	93.75% <0.00%> (+0.41%)	⬆️
src/distance_sets.jl	75.43% <0.00%> (+1.68%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a449c4b...174a826. Read the comment docs.

[joaquimg]

All fails are the same:

Dual Cone: Test Failed at /home/runner/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:215
  Expression: ≈(dΠ, grad_fdm1, atol = tol) || ≈(dΠ, grad_fdm2, atol = tol)
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:464 [inlined]
 [2] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:215 [inlined]
 [3] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [4] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:210 [inlined]
 [5] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [6] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:[175](https://github.com/matbesancon/MathOptSetDistances.jl/runs/5434678975?check_suite_focus=true#step:6:175) [inlined]
 [7] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [8] top-level scope
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:32
Dual Cone: Test Failed at /home/runner/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:215
  Expression: ≈(dΠ, grad_fdm1, atol = tol) || ≈(dΠ, grad_fdm2, atol = tol)
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:464 [inlined]
 [2] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:215 [inlined]
 [3] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [4] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:210 [inlined]
 [5] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [6] macro expansion
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:175 [inlined]
 [7] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/Test/src/Test.jl:1357 [inlined]
 [8] top-level scope
   @ ~/work/MathOptSetDistances.jl/MathOptSetDistances.jl/test/projection_gradients.jl:32

will give some tries

[joaquimg]

Thanks @odow , I havent noticed that.
Since 1.6 is doing well I switched to its rng.

[joaquimg]

last commit should fix #63

[joaquimg]

All Passing!
Good to merge, for me.

[matbesancon]

LGTM! @joaquimg feel free to merge when this passes CI